Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance Factory Deployment via Deploy Libraries #318

Merged
merged 48 commits into from
Dec 18, 2023

Conversation

chapati23
Copy link
Contributor

@chapati23 chapati23 commented Dec 5, 2023

Description

This PR integrates all separate workstreams splitting the governance factory deployment into smaller libraries (one deploy library per contract) in order to circumvent the "contract size too big" issue.

Other changes

  • Updated yarn prettier:check task to be a bit less noisy and log out only files with warnings
  • Renamed contracts and variables according to our shared arch diagram

Tested

  • Wrote unit tests for the new GovernanceFactory.sol

How To Review

Ensure all components of the governance system have been deployed: https://www.figma.com/file/9EgOWuRU0bL0OgFLuLn6j4/Mento-Governance-and-Allocation-Setup-%5BUpdate%5D?type=whiteboard&node-id=0%3A1&t=Y38bJjdYWXRxYa9t-1

Related issues

@chapati23 chapati23 changed the title Draft; Governance Factory Deployment via Deploy Libraries Draft: Governance Factory Deployment via Deploy Libraries Dec 5, 2023
@chapati23 chapati23 marked this pull request as draft December 5, 2023 14:31
Copy link

openzeppelin-code bot commented Dec 7, 2023

Governance Factory Deployment via Deploy Libraries

Generated at commit: 7bc409f5ba13ac133dbff994c299374af01f1031

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
16
38
56
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@chapati23 chapati23 marked this pull request as ready for review December 7, 2023 14:00
@chapati23 chapati23 changed the title Draft: Governance Factory Deployment via Deploy Libraries Governance Factory Deployment via Deploy Libraries Dec 7, 2023
@baroooo baroooo self-requested a review December 7, 2023 14:08
@chapati23 chapati23 requested a review from bowd December 7, 2023 14:17
…ing SARIF report

this should not change the fact that CI fails when slither complains.
because the SARIF report should contain the same errors which then
would make CI fail. But we'd keep the record of issues via SARIF files
which currently is not the case.
@baroooo baroooo mentioned this pull request Dec 18, 2023
2 tasks
Copy link
Contributor

@bowd bowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! One tiny naming nit :shipit:

@chapati23 chapati23 merged commit 4a722be into feat/tokenWork Dec 18, 2023
4 of 15 checks passed
@chapati23 chapati23 deleted the feat/factory-contract-leftovers branch December 18, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants